Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Lofi button to favorites panel #427

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Added Lofi button to favorites panel #427

merged 2 commits into from
Dec 26, 2023

Conversation

ShivaniG14
Copy link

@ShivaniG14 ShivaniG14 commented Oct 21, 2023 •
edited
Loading

Motivation and Context

  • This change includes the existing focus shortcut along with the new lofi girl shortcut. Also few changes in css as mentioned in previous PR discussions.
  • Closes this issue (Add shortcuts for "community favorites")

Types of changes

What types of changes does your code introduce? Check all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Added new lofi girl to community favorites shortcuts. I have changed the lofi girl videoId to "i43tkaTXtwI" from "5qap5aO4i9A" as this video is not available currently.
    Tested it on Safari and Chrome.
Screenshot 2023-10-21 at 12 29 29 PM

Final checklist:

Go over all the following points and check all the boxes that apply
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING guidelines.
  • All tests passed.

@vercel
Copy link

vercel bot commented Oct 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zen-audio-player-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2023 6:33am

@ShivaniG14 ShivaniG14 mentioned this pull request Oct 21, 2023
Closed
shakeelmohamed
shakeelmohamed requested changes Dec 24, 2023
View reviewed changes
Copy link
Member

@shakeelmohamed shakeelmohamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @ShivaniG14, pardon the delay on reviewing.
One nitpick then we are good to go.

index.html Outdated
<i class="fa fa-headphones"></i>
Focus
</button>
<button class="btn " id="lofi-btn">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t notice this before, can we remove the extra space here and on line 113? I know the other one is old.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shakeelmohamed, changes are done. Please check now

@shakeelmohamed shakeelmohamed merged commit e1a3fa6 into zen-audio-player:main Dec 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakeelmohamed shakeelmohamed shakeelmohamed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shortcuts for "community favorites"
2 participants
@ShivaniG14 @shakeelmohamed